Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(LIVE-16653): remove uniswap from history status calls #9143

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix(LIVE-16653): remove uniswap from history status calls #9143

merged 1 commit into from
Feb 18, 2025

Conversation

lpaquet-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Remove uniswap pending history from status calls

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-16653

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lpaquet-ledger lpaquet-ledger requested a review from a team as a code owner February 7, 2025 10:10
@vercel Vercel
Copy link

vercel bot commented Feb 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:12am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Feb 7, 2025 10:12am
native-ui-storybook ⬜️ Ignored (Inspect) Feb 7, 2025 10:12am
react-ui-storybook ⬜️ Ignored (Inspect) Feb 7, 2025 10:12am

@live-github-bot live-github-bot bot added the common Has changes in live-common label Feb 7, 2025
@lpaquet-ledger lpaquet-ledger added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2025
@lpaquet-ledger lpaquet-ledger added this pull request to the merge queue Feb 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2025
@lpaquet-ledger lpaquet-ledger added this pull request to the merge queue Feb 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2025
@lpaquet-ledger lpaquet-ledger added this pull request to the merge queue Feb 18, 2025
Merged via the queue into develop with commit b71a61d Feb 18, 2025
58 checks passed
@lpaquet-ledger lpaquet-ledger deleted the fix/LIVE-16653 branch February 18, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liviuciulinaru liviuciulinaru liviuciulinaru approved these changes

Assignees

@lpaquet-ledger lpaquet-ledger

Labels
common Has changes in live-common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpaquet-ledger @liviuciulinaru